Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-line support in ExtractedComment of PO files #141

Merged
merged 2 commits into from Aug 19, 2020

Conversation

Darkmet98
Copy link
Contributor

Description

This fixes bad readings and bad writtings for some entries from PoEntry on the Po2Binary and Binary2Po classes.

Linked issue:
This closses #140

@pleonex pleonex changed the title Fixed bad newlines for Po2Binary and Binary2Po Fix multi-line support in ExtractedComment of PO files Aug 19, 2020
@pleonex pleonex added this to the vNext milestone Aug 19, 2020
Copy link
Member

@pleonex pleonex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot and sorry for the delay! All good.

@pleonex pleonex merged commit 95d3fea into SceneGate:develop Aug 19, 2020
@github-actions
Copy link

🎉 This issue has been resolved in version v3.1.0 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extracted comments with multi lines is splitted by space instead of new line on Binary2Po
2 participants