Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set FileOpenMode at NodeFactory.FromFile #165

Merged
merged 3 commits into from Feb 24, 2021
Merged

Set FileOpenMode at NodeFactory.FromFile #165

merged 3 commits into from Feb 24, 2021

Conversation

Kaplas80
Copy link
Contributor

@Kaplas80 Kaplas80 commented Feb 24, 2021 •
edited

Description

Adds a parameter to configure the permissions at NodeFactory.FromFile and NodeFactory.FromDirectory methods.

Example

Node node = NodeFactory.FromFile(tempFile, FileOpenMode.Read);

If no parameter is passed, it defaults to FileOpenMode.ReadWrite

This closes #164

pleonex
pleonex approved these changes Feb 24, 2021
View reviewed changes
Copy link
Member

@pleonex pleonex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@pleonex pleonex added this to the vNext milestone Feb 24, 2021
@pleonex pleonex merged commit 019d316 into SceneGate:develop Feb 24, 2021
@Kaplas80 Kaplas80 deleted the fix/read-only-files branch February 25, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleonex pleonex pleonex approved these changes

Assignees
No one assigned
Labels
enhancement IO
Projects
None yet
Milestone
v4.0
Development

Successfully merging this pull request may close these issues.

Can't read a file with readonly attribute
2 participants
@Kaplas80 @pleonex