Advanced filter in FromDirectory #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleonex
requested changes
Mar 13, 2021
src/Yarhl/FileSystem/NodeFactory.cs
Outdated
| if (string.IsNullOrEmpty(dirPath)) | ||
| throw new ArgumentNullException(nameof(dirPath)); | ||
|
|
||
| if (dirPath[dirPath.Length - 1] == Path.DirectorySeparatorChar) |
There was a problem hiding this comment.
The one-line conditions not related to guards should have braces to prevent future bugs (the previous function doesn't follow this rule this rule but I think it's old code before this rule was introduced).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows using a
Functo define the filter inNodeFactory.FromDirectorymethods.This way, the users can define more precisely the files to add to the container.
On the other side, this method will be slower than wildcard filters because it first enumerates all files and, later, filters them.
Example
Get files using a regular expression: