Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DataStream type in Stream properties for readers and writers and explicitly set CanTimeout to false #172

Merged
merged 1 commit into from Oct 15, 2021

Conversation

pleonex
Copy link
Member

@pleonex pleonex commented Oct 15, 2021

Description

Get again all the advantages of DataStream from the properties of DataReader, DataWriter, TextDataReader and TextDataWriter.
This reduces the amount of breaking changes introduced by this release.

Also set CanTimeout to false and return invalid values for ReadTimeout and WriterTimeout. The default implementation is to throw an exception and that make almost impossible to use some reflection in the type. For instance in debuggers or in UI controls that display automatically the value of the properties.

Example

using var stream = new DataStream();
var reader = new DataReader(stream);
reader.Stream.PushPosition();

@pleonex pleonex added this to the vNext milestone Oct 15, 2021
@pleonex pleonex self-assigned this Oct 15, 2021
@pleonex pleonex changed the title Use DataStream type in Stream properties for readers and writers and explicetely set CanTimeout to false Use DataStream type in Stream properties for readers and writers and explicitly set CanTimeout to false Oct 15, 2021
@pleonex pleonex merged commit 78c7389 into develop Oct 15, 2021
@pleonex pleonex deleted the feature/reduce-io-breaking branch October 15, 2021 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant