Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Implement extension methods to transform node collections #201

Merged
merged 2 commits into from Nov 24, 2023

Conversation

pleonex
Copy link
Member

@pleonex pleonex commented Nov 24, 2023

Implement the three overloads of TransformWith to IEnumerable<Node> and NavigableNodeCollection<Node>, so that we can transform all the nodes in one line.

This PR closes #194

Quality check list

  • Related code has been tested automatically or manually
  • Related documentation is updated
  • I acknowledge I have read and filled this checklist and accept the
    developer certificate of origin

Acceptance criteria

  • We can transform children with the same converter in one line

Follow-up work

None

Example

using Node overlays = NodeFactory.FromDirectory("overlays");
overlays.Children.TransformCollectionWith<BlzDecompressor>();

@pleonex pleonex added this to the v4.0 milestone Nov 24, 2023
@pleonex pleonex self-assigned this Nov 24, 2023
@pleonex pleonex marked this pull request as ready for review November 24, 2023 11:46
@pleonex pleonex merged commit 38e4d7b into develop Nov 24, 2023
5 checks passed
@pleonex pleonex deleted the feature/194-transform-children branch November 24, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve API to transform all children nodes
1 participant