Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 WriteTo truncates output file #203

Merged
merged 2 commits into from Nov 28, 2023
Merged

Conversation

pleonex
Copy link
Member

@pleonex pleonex commented Nov 28, 2023

DataStream.WriteTo now truncates the output file. Before if the file existed, it was opening and overwriting data. This could have caused unexpected results as the output file may have not contained exactly the same content as the source stream.

Quality check list

  • Related code has been tested automatically or manually
  • Related documentation is updated
  • I acknowledge I have read and filled this checklist and accept the
    developer certificate of origin

Acceptance criteria

  • WriteTo truncates the file if exists

Follow-up work

none

Example

API doesn't change.

@pleonex pleonex added the bug label Nov 28, 2023
@pleonex pleonex added this to the v4.0 milestone Nov 28, 2023
@pleonex pleonex self-assigned this Nov 28, 2023
@pleonex pleonex merged commit d3e4e14 into develop Nov 28, 2023
5 checks passed
@pleonex pleonex deleted the feature/writeto-truncate branch November 28, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant