Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RIP Renderable - Welcome Model (typealias FilamentAsset) #44

Closed
ThomasGorisse opened this issue Mar 14, 2022 · 2 comments
Closed

RIP Renderable - Welcome Model (typealias FilamentAsset) #44

ThomasGorisse opened this issue Mar 14, 2022 · 2 comments
Assignees
@ThomasGorisse
Labels
enhancement New feature or request Stale

Comments

@ThomasGorisse
Copy link
Contributor

Before moving the PlaneVisualizer to Kotlin let's decide what to do with the Renderable and RenderableInstance classes: #40

Big subject here even if I'm conviced that most of the Renderable and RenderableInstance with the old sfb managed can be cleaned quite quickly. Resulting in a quite simple class.

Originally posted by @ThomasGorisse in #39 (comment)
@ThomasGorisse ThomasGorisse self-assigned this Mar 14, 2022
@ThomasGorisse ThomasGorisse mentioned this issue Mar 15, 2022
Closed
@ThomasGorisse ThomasGorisse added the enhancement New feature or request label Mar 19, 2022
@ThomasGorisse ThomasGorisse changed the title ModelNode - Renderable -> ModelNode.model: FilamentAsset? RIP Renderable - Welcome FilamentAsset (typealias Model) Mar 28, 2022
@ThomasGorisse ThomasGorisse changed the title RIP Renderable - Welcome FilamentAsset (typealias Model) RIP Renderable - Welcome Model (typealias FilamentAsset) Mar 28, 2022
@github-actions
Copy link

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Jun 27, 2022
@github-actions
Copy link

github-actions bot commented Jul 4, 2022

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@github-actions github-actions bot closed this as completed Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomasGorisse ThomasGorisse

Labels
enhancement New feature or request Stale
Projects
SceneView Future Release
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ThomasGorisse