Changed the default mode for the PlaneRenderer.

[RGregat]

PlaneRenderMode.RENDER_ALL was set as the default mode but the doc states clearly that this mode is very expensive. A short check on the Profile verified this statement with 500ms spikes. The default mode is now set to PlaneRenderMode.RENDER_TOP_MOST.

[ThomasGorisse]

Great found @RGregat !!!
I couldn't figure out why was the last Model Viewer laggy after some planes detected.
We definitely have to move the PlaneVisualizer to kotlin. It can easily be a PlaneNode and ShadowPlaneNode.
@RGregat Would you mind doing it just like in the answer you made there #30 (comment) ?
I think that because glTF is at the end not so consuming comparing to programmatic mesh, maybe it could be a lot cleaner and customizable for users to use a Plane.glb and ShadowPlane.glb choice here.
I don't know if it's an issue with ARCore polygons @grassydragon ?

[grassydragon]

It can easily be a PlaneNode and ShadowPlaneNode.

Won't adding and removing many Nodes create a lot of objects for garbage collection?

I don't know if it's an issue with ARCore polygons @grassydragon?

I think we can only generate the polygons at runtime.

[grassydragon]

Is the topMostPlane actually the top most here?

sceneview-android/arsceneview/src/main/kotlin/io/github/sceneview/ar/scene/PlaneRenderer.kt

Line 156 in 7ad2ec4

arFrame.updatedPlanes.firstOrNull()?.let { topMostPlane ->

[grassydragon]

Before moving the PlaneVisualizer to Kotlin let's decide what to do with the Renderable and RenderableInstance classes: #40

[ThomasGorisse]

Is the topMostPlane actually the top most here?

sceneview-android/arsceneview/src/main/kotlin/io/github/sceneview/ar/scene/PlaneRenderer.kt

Line 156 in 7ad2ec4

arFrame.updatedPlanes.firstOrNull()?.let { topMostPlane ->

Yes it should
There is definetly something to do to clean this part:

sceneview-android/arsceneview/src/main/kotlin/io/github/sceneview/ar/scene/PlaneRenderer.kt

Lines 134 to 162 in 3140b34

	if (isVisible) {
	// If we hit a plane, return the hit point.
	val hitResult = arFrame.hitTest(
	xPx = session.displayWidth / 2.0f,
	yPx = session.displayHeight / 2.0f,
	plane = true,
	depth = false,
	instantPlacement = false
	)
	// Calculate the focusPoint. It is used to determine the position of
	// the visualized grid.
	val focusPoint = getFocusPoint(arFrame.frame, hitResult)
	materialInstance?.setParameter(
	MATERIAL_SPOTLIGHT_FOCUS_POINT,
	Position(focusPoint.x, focusPoint.y, focusPoint.z)
	)
	}
	if (planeRendererMode == PlaneRendererMode.RENDER_ALL) {
	renderAll(session.allPlanes)
	} else if (planeRendererMode == PlaneRendererMode.RENDER_TOP_MOST) {
	arFrame.updatedPlanes.firstOrNull()?.let { topMostPlane ->
	renderPlane(topMostPlane)
	}
	}
	// Check for not tracking Plane-Trackables and remove them.
	cleanupOldPlaneVisualizer()

[ThomasGorisse]

It can easily be a PlaneNode and ShadowPlaneNode.

Won't adding and removing many Nodes create a lot of objects for garbage collection?

You are probably right even if it would bring some great Node features we can use directly here.

I don't know if it's an issue with ARCore polygons @grassydragon?

I think we can only generate the polygons at runtime.

Would you mind doing the move from RenderableDefinittion to Filament direct mesh creation?
I definetly don't feel confortable with the mesh creation.

[ThomasGorisse]

Before moving the PlaneVisualizer to Kotlin let's decide what to do with the Renderable and RenderableInstance classes: #40

Big subject here even if I'm conviced that most of the Renderable and RenderableInstance with the old sfb managed can be cleaned quite quickly. Resulting in a quite simple class.

[grassydragon]

Would you mind doing the move from RenderableDefinittion to Filament direct mesh creation?

We just need to make sure that we aren't missing any important features that Sceneform provided for mesh creation. I actually only used the direct Filament approach.

[RGregat]

Is this an example for the filament way to create a mesh? https://github.com/google/filament/blob/main/samples/hellotriangle.cpp

[ThomasGorisse]

Is this an example for the filament way to create a mesh? https://github.com/google/filament/blob/main/samples/hellotriangle.cpp

This is the C++ version.
I created an Issue for each points of this discussion.
Answer here: #43