Skip to content

Commit

Permalink
Revert "Dev admin img url (#529)"
Browse files Browse the repository at this point in the history
This reverts commit 084df17.
  • Loading branch information
Taehoya committed Aug 26, 2023
1 parent 084df17 commit 04b5a18
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 15 deletions.
10 changes: 2 additions & 8 deletions src/controllers/Admin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -522,11 +522,6 @@ export const createPerfume: RequestHandler = async (
* in: formData
* type: file
* description: uploaded file
* - name: perfumeIdx
* in: query
* required: true
* type: integer
* format: int64
* responses:
* 200:
* description: success
Expand All @@ -548,15 +543,14 @@ export const createPerfumeImg: RequestHandler = async (
req: Request,
res: Response
) => {
console.log(req.file);
if (!req.file)
return res
.status(400)
.json({ error: 'cannot find file from the request' });
const imageUrl = await createImageUrl(req.file);
const perfumeIdx: number = Number(req.query.perfumeIdx);

try {
await Perfume.createImg(imageUrl, perfumeIdx);
await Perfume.createImg(imageUrl);
res.status(StatusCode.OK).json({
message: '성공',
});
Expand Down
4 changes: 2 additions & 2 deletions src/dao/PerfumeDao.ts
Original file line number Diff line number Diff line change
Expand Up @@ -470,12 +470,12 @@ class PerfumeDao {
});
}

async createImg(imageUrl: string | any, perfumeIdx: number) {
async createImg(imageUrl: string | any) {
const created = await Perfume.update(
{
imageUrl,
},
{ where: { perfumeIdx } }
{ where: {} }
);
return created;
}
Expand Down
15 changes: 12 additions & 3 deletions src/service/ImageService.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import S3FileDao from '@src/dao/S3FileDao';
import config from '../config/config';
import fs from 'fs';
import AWS from 'aws-sdk';
import {
DuplicatedEntryError,
FailedToCreateError,
} from '@src/utils/errors/errors';
import storage from '../config/s3Config';

class ImageService {
s3FileDao: S3FileDao;
Expand Down Expand Up @@ -33,20 +33,29 @@ class ImageService {
fileData: Express.Multer.File
): Promise<string> {
try {
console.log('Inside the Service');
const fileContent: Buffer = fs.readFileSync(fileData.path);
const keyWithPrefix = `perfumes/${fileData.originalname}`;

const storage: AWS.S3 = new AWS.S3({
accessKeyId: process.env.AWS_ACCESS_KEY_ID,
secretAccessKey: process.env.AWS_SECRET_ACCESS_KEY,
region: 'ap-northeast-2',
});
console.log('Inside the Service2');

const params: {
Bucket: string;
Key: string;
Body: Buffer;
} = {
Bucket: config.development.bucketName as string,
Key: keyWithPrefix,
Key: fileData.originalname,
Body: fileContent,
};
console.log('Inside the Service3');

const result = await storage.upload(params).promise();
console.log(result.Location);
return result.Location;
} catch (err: Error | any) {
if (err.parent?.errno === 1062) {
Expand Down
4 changes: 2 additions & 2 deletions src/service/PerfumeService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -497,9 +497,9 @@ class PerfumeService {
}
}

async createImg(imageUrl: string, perfumeIdx: number) {
async createImg(imageUrl: string) {
try {
return await perfumeDao.createImg(imageUrl, perfumeIdx);
return await perfumeDao.createImg(imageUrl);
} catch (err: Error | any) {
if (err.parent?.errno === 1062) {
throw new DuplicatedEntryError();
Expand Down

0 comments on commit 04b5a18

Please sign in to comment.