Dao- changing from then to async #491
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
에러 잡아서 다시 커밋 할게요! |
neverlish
reviewed
May 18, 2023
| pagingDTO ? pagingDTO.sequelizeOption() : {} | ||
| ) | ||
| ); | ||
| // const result = await Ingredient.findAndCountAll( |
There was a problem hiding this comment.
불필요한 주석은 모두 지워주면 좋겠다는 생각이 들어요!
이전 코드를 봐야 할 필요가 있다면 git에 남아있는 이력을 추적하면 되니까요
neverlish
reviewed
May 18, 2023
| ); | ||
| }); | ||
| return new ListAndCountDTO<BrandDTO>(result.count, rows); | ||
| } catch (error) { |
There was a problem hiding this comment.
에러 catch 이후에 별다른 처리 없이 바로 throw를 한다면, try-catch 를 굳이 하지 않아도 좋을거 같아요
|
PR의 base branch를 main이 아니라 dev 로 바꿔주세요~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
What's being changed:
except for 4 files in Dao, changed codes which use then to async