Move pdf support check from viewer to renderer #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently not able to test pdfx viewer components in CI, as the viewer components assert that the current device has PDF support, and our CI is running linux. We've mocked out the pdf renderer, and we're supplying a MockPdfDocument to
PdfView, which works fine on MacOS, but fails in CI. By moving the check to the renderer we can successfully test PdfView in CI.I also removed
PdfViewState._currentIndex. The main reason is because it waslateinited, and removing theawait hasPdfSupportcheck meant that it started being accessed before it was inited. It also had an off by one error on initialisation. Instead, we can just use the current value of thepageListenable.