Skip to content

Commit

Permalink
Fix to aftercorr job array dependency logic
Browse files Browse the repository at this point in the history
Fix job array dependency with "aftercorr" option and some task arrays in
    the first job fail. This fix lets all task array elements that can run
    proceed rather than stopping all subsequent task array elements.
Bug 4590
  • Loading branch information
fafik23 authored and jette committed Jan 12, 2018
1 parent deaacad commit 7b5a367
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
3 changes: 3 additions & 0 deletions NEWS
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ documents those changes that are of interest to users and administrators.
reconfigured.
-- node_feature/knl_cray - Fix memory leak that can occur during normal
operation.
-- Fix job array dependency with "aftercorr" option and some task arrays in
the first job fail. This fix lets all task array elements that can run
proceed rather than stopping all subsequent task array elements.

* Changes in Slurm 17.02.9
==========================
Expand Down
6 changes: 5 additions & 1 deletion src/slurmctld/job_scheduler.c
Original file line number Diff line number Diff line change
Expand Up @@ -2716,7 +2716,11 @@ extern int test_job_dependency(struct job_record *job_ptr)
depends = true;
else if (array_complete)
clear_dep = true;
else {
else if (job_ptr->array_recs &&
(job_ptr->array_task_id ==
NO_VAL)) {
depends = true;
} else {
failure = true;
break;
}
Expand Down

0 comments on commit 7b5a367

Please sign in to comment.