Commits on Dec 9, 2023

1. Append the array contents, not the array itself …

   Without this, lines becomes:
   
   ```
   [
     ...,
     "<!-- SCHEMA_DEV: TEMPLATE #{key} - begin -->\n",
     "<!-- These lines are auto-inserted from a schema_dev template -->\n",
     [
       "template line 1\n",
       "template line 2\n",
       ...
     ],
     "\n",
     "<!-- SCHEMA_DEV: TEMPLATE #{key} - end -->\n",
     ...
   ]
   ```
   
   Then subsequent replacements fail because they choke on the array in the
   middle. Like:
   
   ```
   .../schema_dev-4.2.0/lib/schema_dev/readme.rb:68:in `!~': undefined method `=~' for ["As usual:\n", "\n", "```ruby\n", "gem \"<%= gem_name %>\"                # in a Gemfile\n", "gem.add_dependency \"<%= gem_name %>\" # in a .gemspec\n", "```\n"]:Array (NoMethodError)
   
     before = lines.take_while { |line| line !~ pattern }
                                             ^^
     from .../schema_dev-4.2.0/lib/schema_dev/readme.rb:68:in `block in replace_block'
   ```
   
   After this change:
   
   ```
   [
     ...,
     "<!-- SCHEMA_DEV: TEMPLATE #{key} - begin -->\n",
     "<!-- These lines are auto-inserted from a schema_dev template -->\n",
     "template line 1\n",
     "template line 2\n",
     ...,
     "\n",
     "<!-- SCHEMA_DEV: TEMPLATE #{key} - end -->\n",
     ...
   ]
   ```

   

   sj26 committed Dec 9, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for e0b3861
   • Browse repository at this point

   Copy the full SHA

   e0b3861 View commit details

   Browse the repository at this point in the history