Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Rails 5.2 #15

Closed
wants to merge 1 commit into from
Closed

Add support for Rails 5.2 #15

wants to merge 1 commit into from

Conversation

jeremyyap
Copy link
Contributor

ActiveRecord::ConnectionAdapters::IndexDefinition was changed here rails/rails@1a92ae8

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.4%) to 98.561% when pulling dbeeede on jeremyyap:rails-5_2 into ba867bc on SchemaPlus:master.

@coveralls
Copy link

coveralls commented Oct 4, 2018 •
edited

Coverage Status

Coverage decreased (-1.8%) to 98.235% when pulling c879f58 on jeremyyap:rails-5_2 into ba867bc on SchemaPlus:master.

@jeremyyap
Copy link
Contributor Author

I think the remaining failing tests for postgresql on ActiveRecord 4.2 can be fixed by publishing a new version of schema_dev with the changes in SchemaPlus/schema_dev#21.

This was referenced Nov 28, 2018
Closed
Closed
@urkle
Copy link
Member

urkle commented Nov 30, 2018

@jeremyyap can you

  1. update to the latest schema_dev
  2. run schema_dev freshen to update the gemfiles in this repo
  3. check in those changes.

Then tests should fully pass and we can get a new version of this gem out.

@urkle urkle self-assigned this Nov 30, 2018
@urkle urkle added this to In progress in Rails 5.2 Support Nov 30, 2018
@urkle
Copy link
Member

urkle commented Nov 30, 2018

Closing in favor of #16 which is based on this PR.

@urkle urkle closed this Nov 30, 2018
Rails 5.2 Support automation moved this from In progress to Done Nov 30, 2018
@jeremyyap jeremyyap deleted the rails-5_2 branch December 1, 2018 03:35
@urkle urkle mentioned this pull request Dec 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@urkle urkle

Labels
None yet
Projects
Rails 5.2 Support
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jeremyyap @coveralls @urkle