Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Active Record 5 #4

Merged
merged 10 commits into from
Aug 24, 2016
Merged

Support for Active Record 5 #4

merged 10 commits into from
Aug 24, 2016

Commits on Aug 14, 2016

  1. Update .gemspec to depend on schema_plus_core 2.0 

    Signed-off-by: Alex Coles <alex@alexbcoles.com>
    @myabc
    myabc committed Aug 14, 2016
    Configuration menu
    Copy the full SHA
    6d5579a View commit details
    Browse the repository at this point in the history

  2. Only test against ActiveRecord 5.0, Ruby 2.3.0

    @myabc
    myabc committed Aug 14, 2016
    Configuration menu
    Copy the full SHA
    349fd7e View commit details
    Browse the repository at this point in the history

  3. Update deprecated #tables to #data_sources 

    Signed-off-by: Alex Coles <alex@alexbcoles.com>
    @myabc
    myabc committed Aug 14, 2016
    Configuration menu
    Copy the full SHA
    e543c18 View commit details
    Browse the repository at this point in the history

  4. Explicitly override PostgreSQLAdapter#remove_index 

    Signed-off-by: Alex Coles <alex@alexbcoles.com>
    @myabc
    myabc committed Aug 14, 2016
    Configuration menu
    Copy the full SHA
    3587d52 View commit details
    Browse the repository at this point in the history

  5. Specify Migration version for CommandRecorder spec 

    Signed-off-by: Alex Coles <alex@alexbcoles.com>
    @myabc
    myabc committed Aug 14, 2016
    Configuration menu
    Copy the full SHA
    95d51a0 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2016

  1. Explicitly override SQLite3Adapter#remove_index 

    Signed-off-by: Alex Coles <alex@alexbcoles.com>
    @myabc
    myabc committed Aug 16, 2016
    Configuration menu
    Copy the full SHA
    91d97ce View commit details
    Browse the repository at this point in the history

  2. Add sanity check to Schema::SQLite3::Indexes 

    Currently the `Result` returned includes auto-generated indexes
e.g. `sqlite_autoindex_ar_internal_metadata_1` for which the `sql`
value will always be `nil`.

Signed-off-by: Alex Coles <alex@alexbcoles.com>
    @myabc
    myabc committed Aug 16, 2016
    Configuration menu
    Copy the full SHA
    e5371fd View commit details
    Browse the repository at this point in the history

  3. Revert "Update deprecated #tables to #data_sources" 

    In these cases, `#tables` is actually the appropriate method.

This reverts commit e543c18.
    @myabc
    myabc committed Aug 16, 2016
    Configuration menu
    Copy the full SHA
    02283eb View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2016

  1. Bump tested Ruby to 2.3.1 

    Signed-off-by: Alex Coles <alex@alexbcoles.com>
    @myabc
    myabc committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    1b4cfee View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2016

  1. DRY up: Extract #remove_index override into Module 

    Signed-off-by: Alex Coles <alex@alexbcoles.com>
    @myabc
    myabc committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    0c9d021 View commit details
    Browse the repository at this point in the history