Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow replace with views #5

Merged
merged 3 commits into from
Jun 2, 2015

Conversation

hcarver
Copy link
Contributor

@hcarver hcarver commented Jun 2, 2015

Refactored as you suggested, added some documentation and tests. The instructions for setting up a dev environment didn't work for me, so I'm just crossing my fingers that the test passes!

Allow for the option to replace a view, not just create one.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling fd02c22 on hcarver:allow_replace_with_views into 5be4f13 on SchemaPlus:master.

@ronen
Copy link
Member

ronen commented Jun 2, 2015

@hcarver cool looks good. Only one thing i might add to the doc is something along the lines of "subject to the some limitations; see the MySQL and PostgreSQL docs for details". But no need to make you go back again, i'll just merge and then edit it myself.

The instructions for setting up a dev environment didn't work for me

Bummer. What didn't work?

so I'm just crossing my fingers that the test passes!

It does!

ronen added a commit that referenced this pull request Jun 2, 2015
@ronen ronen merged commit 6531bb1 into SchemaPlus:master Jun 2, 2015
@ronen
Copy link
Member

ronen commented Jun 2, 2015

Actually I noticed that :force wasn't documented at all! So I added documentation for both it and :allow_replace in the "Creating Views" section (moved your doc over).

I've release version 0.2.0 with this in it. Thanks for your contribution!

@hcarver
Copy link
Contributor Author

hcarver commented Jun 3, 2015

No problem!

I couldn't find a single set of instructions to follow, but I eventually realised I needed ruby 2.1.5, and to install the schema_dev gem (it wasn't installing under ruby 2.0.0, which is probably not a problem if development is intended to only be done on 2.1.5).

I can't remember exactly what the next error I had was, but I think it was around creating the databases needed.

@ronen
Copy link
Member

ronen commented Jun 4, 2015

I eventually realized I needed... to install the schema_dev gem.

OK, yeah, that should be clearer. And the README over there should give better setup instructions. I've added an issue SchemaPlus/schema_dev#9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants