Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catalog.json is ambiguous for .github/ISSUE_TEMPLATE/config.yml #2364

Open
alexrp opened this issue Jul 22, 2022 · 2 comments
Open

catalog.json is ambiguous for .github/ISSUE_TEMPLATE/config.yml #2364

alexrp opened this issue Jul 22, 2022 · 2 comments
Labels
fileMatch-conflict Wrong schema triggered for this json.

Comments

@alexrp
Copy link

alexrp commented Jul 22, 2022

Area with issue?

Web server

✔️ Expected Behavior

The GitHub issue forms schema entry in catalog.json should not match .github/ISSUE_TEMPLATE/config.yml.

❌ Actual Behavior

The GitHub issue forms schema in catalog.json matches .github/ISSUE_TEMPLATE/*.yml, which necessarily includes .github/ISSUE_TEMPLATE/config.yml, which is also matched by GitHub Issue Template configuration.

YAML or JSON file that does not work.

Any valid .github/ISSUE_TEMPLATE/config.yml, e.g.:

# yaml-language-server: $schema=https://json.schemastore.org/github-issue-config.json
blank_issues_enabled: false

IDE or code editor.

Visual Studio Code

Are you making a PR for this?

No, someone else must create the PR.

@alexrp alexrp added the Issue-Bug Report errors or unexpected behavior (auto-generated by issue forms) label Jul 22, 2022
@alexrp
Copy link
Author

alexrp commented Jul 22, 2022

I picked "no" for the PR question because I have no idea if this is actually a bug here or in the YAML language server, and in either case, I'm not sure what the proper fix even is. My immediate thought was an exclusion on the file matchers for GitHub issue forms but it doesn't seem like that's an actual feature in catalog.json...

@yihongang
Copy link
Contributor

@hyperupcall hyperupcall added the fileMatch-conflict Wrong schema triggered for this json. label Aug 5, 2023
@hyperupcall hyperupcall removed the Issue-Bug Report errors or unexpected behavior (auto-generated by issue forms) label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fileMatch-conflict Wrong schema triggered for this json.
Projects
None yet
Development

No branches or pull requests

3 participants