Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow TVrage Episode Numbering #20

Closed
grantd opened this issue Feb 22, 2014 · 5 comments
Closed

Allow TVrage Episode Numbering #20

grantd opened this issue Feb 22, 2014 · 5 comments

Comments

@grantd
Copy link

grantd commented Feb 22, 2014

Optionally allow TVrage episode numbering per show.

TVDB has given up trying to number shows from the history channel like pawn stars and has started using a year based numbering system such as S2014E01. The numbering system objectively makes some sense but makes SickBeard useless for finding those episodes.

@SchizoDuckie
Copy link
Owner

Thanks for the example.If any more edge cases on tvdb please add them to this ticket

@SchizoDuckie
Copy link
Owner

After some hours of fiddling, i've got a reasonably well working matching algorithm.

Will post a patch tomorrow.

@grantd
Copy link
Author

grantd commented Feb 23, 2014

Glad to hear that things are moving along so quickly. I'll be sure to check it out when I get a chance.

@SchizoDuckie
Copy link
Owner

Fixed with the creation of https://github.com/SchizoDuckie/seriesguide-chrome/blob/5401d8fcb8b0a183703f2f42a39ea337366252fa/js/seriesguide.tvrage.sync.js

Introduced a new dropdown under the episodes column with a magic button:
image

When pressed there's only one that doesn't match:
image

For matching an episode from TVDB to TVRage I fiddled around until I came up with these conditions:

  • the names match with '&' changed to 'and'
  • or just the text without non-word characters matches (slightly different spelling)
  • or the episode title has a prefix on tvrage (250th episode:
  • or the episode title is different on tvrage, but it matches on episode number and date

In the example you can see there's one episode left, I couldn't match this in any of the ways to one related in the TVRage DB. Thinking about a simple double-click-to-edit on the episodenumber column if you want to change that by hand

@SchizoDuckie
Copy link
Owner

I've updated the matching algorithm and it now also finds the last episode shown above in the screenshot. It seems to work so good now that i'm fetching an episodes update from tvrage by default after adding a series (see commits above)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants