Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify meaning of perf_metric_diff #238

Merged
merged 7 commits into from
Dec 3, 2020
Merged

Clarify meaning of perf_metric_diff #238

merged 7 commits into from
Dec 3, 2020

Conversation

kelly-sovacool
Copy link
Member

@kelly-sovacool kelly-sovacool commented Dec 3, 2020 •
edited
Loading

Issues

NA

Change(s) made

  • Clarified the meaning of perf_metric_diff in get_feature_importance() and the intro vignette.
  • Snuck in minor changes to remove the term "robust" from docs (per JW's paper revisions).

Checklist

  • Update NEWS.md if this includes any user-facing changes. Strikethrough if not applicable.
  • The check workflow succeeds on your most recent commit.

@zenalapp zenalapp merged commit cb8a452 into master Dec 3, 2020
@zenalapp zenalapp deleted the docs branch December 3, 2020 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zenalapp zenalapp zenalapp approved these changes

@courtneyarmour courtneyarmour Awaiting requested review from courtneyarmour

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kelly-sovacool @zenalapp