Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make taxon_level a char instead of a data var for pool_taxon_counts() #43

Merged
merged 12 commits into from
Nov 15, 2022

Conversation

kelly-sovacool
Copy link
Member

@kelly-sovacool kelly-sovacool commented Nov 5, 2022

Change(s) made

  • The taxon_level argument is now a character instead of a data variable. This should prevent hard-to-catch bugs where users give the wrong type. The internal code is actually simpler now with no embracing ({{ taxon_level }}) & only one instance of !!rlang::sym(taxon_level).
  • Bump r-lib/actions to v2 in github actions workflows (v1 no longer works).

Checklist

(Strikethrough any points that are not applicable.)

  • Write unit tests for any new functionality.
  • Update roxygen comments & vignettes if there are any API changes.
  • Update NEWS.md if this includes any user-facing changes.
  • The check workflow succeeds on your most recent commit.

@kelly-sovacool kelly-sovacool marked this pull request as ready for review November 5, 2022 19:09
@kelly-sovacool kelly-sovacool requested review from a team and sklucas and removed request for a team November 5, 2022 19:09
@sklucas sklucas merged commit f0632ea into main Nov 15, 2022
@sklucas sklucas deleted the pool-counts-refactor branch November 15, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants