Skip to content
This repository has been archived by the owner on Jul 9, 2022. It is now read-only.

Attachment forwarding #435

Merged
merged 6 commits into from Apr 1, 2017
Merged

Conversation

gamelaster
Copy link
Contributor

You can forward various attachments for multiple users.
Actually I tested videos and images. GIFs should work too.
Can anyone test forwading files and audio files?

@ravkr
Copy link
Contributor

ravkr commented Mar 30, 2017

wow, i'm impressed! 😄

}

defaultFuncs
.post("https://www.messenger.com/mercury/attachments/forward/?dpr=1", ctx.jar, form)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would imagine you can remove that ?dpr=1 param. Could you double check if it works without?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed, It's works good without it

DOCS.md Outdated
Takes a userID or an array of userIDs and forward the corresponding attachment.

__Arguments__
* `attachmentID`: A attachment ID (usualy `attribute.ID` property)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rephrase this to be:

The ID field in the attachment object. Not all attachment have IDs: recorded audio and arbitrary files don't for example.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a lot for this, I still have problems with describing arguments (Or anything other). My English vocabulary and grammar is still bad.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, you're doing great! It's a tricky thing to get perfect.
(Don't worry, @bsansouci's first language is French so he understands how you feel)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To add my few cents: my first language is Polish 😄

@bsansouci
Copy link
Collaborator

It seems that I cannot forward audio files or files from the UI. So it's ok to not cover it (we don't get ID from them).

I added some comments. I can merge once you've fixed them.

@gamelaster
Copy link
Contributor Author

Thank you a lot for comments! I solved all of them!

DOCS.md Outdated
<a name="forwardAttachment"></a>
### api.forwardAttachment(attachmentID, userOrUsers[, callback])

Takes a userID or an array of userIDs and forward the corresponding attachment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rephrase it this way:
"Forwards corresponding attachment to given userID or to every user from an array of userIDs"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@bsansouci bsansouci merged commit 29f734a into Schmavery:master Apr 1, 2017
@bsansouci
Copy link
Collaborator

Awesommmmeee! Merging!

how2945ard pushed a commit to how2945ard/facebook-chat-api that referenced this pull request May 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants