This repository has been archived by the owner on Jul 9, 2022. It is now read-only.
fixes to setReaction #437
Merged
fixes to setReaction #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schmavery
reviewed
Mar 30, 2017
DOCS.md
Outdated
|
|
||
| __Arguments__ | ||
|
|
||
| * `reaction`: A string contains `emoji`, `emoji shortcut`, `emoji in unicode` or left `empty string` for delete reaction (look down for list of supported emojis). |
There was a problem hiding this comment.
Can you change this to:
A string containing either an emoji, an emoji in unicode, or an emoji shortcut (see list of supported emojis below). The string can be left empty ("") in order to remove a reaction.
change `addReaction` to `setReaction` in error message place docs to setReaction in alphabetical order make table with emojis remove some trailing spaces
|
Eeeeh >< sorry for that many issues |
|
No problem @gamelaster! We're all working together 😄 |
bsansouci
pushed a commit
that referenced
this pull request
Apr 1, 2017
change `addReaction` to `setReaction` in error message place docs to setReaction in alphabetical order make table with emojis remove some trailing spaces
how2945ard
pushed a commit
to how2945ard/facebook-chat-api
that referenced
this pull request
May 30, 2017
change `addReaction` to `setReaction` in error message place docs to setReaction in alphabetical order make table with emojis remove some trailing spaces
how2945ard
pushed a commit
to how2945ard/facebook-chat-api
that referenced
this pull request
May 30, 2017
change `addReaction` to `setReaction` in error message place docs to setReaction in alphabetical order make table with emojis remove some trailing spaces
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change
addReactiontosetReactionin error messageplace docs to setReaction in alphabetical order
make table with emojis
remove some trailing spaces