Reply message feature & Some bug fixes #721
Conversation
|
Attachments need to be formatted correctly |
|
Is there a way to add this without copying most of sendMessage? |
|
sorry for late response |
|
bump |
|
Additional bump :) |
|
@Schmavery please, check this out |
BadAimWeeb
changed the title
|
@Schmavery bump |
| @@ -303,7 +303,7 @@ module.exports = function(defaultFuncs, api, ctx) { | |||
| cb(); | |||
| } | |||
|
|
|||
| return function sendMessage(msg, threadID, callback) { | |||
| return function sendMessage(msg, threadID, callback, replyToMessage) { | |||
There was a problem hiding this comment.
The callback is supposed to be optional, but this makes it so that you can't pass a reply without a callback.
DOCS.md
Outdated
| @@ -1372,7 +1428,7 @@ __Arguments__ | |||
| --------------------------------------- | |||
|
|
|||
| <a name="sendMessage"></a> | |||
| ### api.sendMessage(message, threadID[, callback]) | |||
| ### api.sendMessage(message, threadID[, callback[, messageID]]) | |||
There was a problem hiding this comment.
What does it mean for the [[]] to be nested? That you can't pass messageId without callback? Why?
There was a problem hiding this comment.
I don't have a lot of time for this library these days but I try to merge obvious bug fixes when I see them. I avoid merging new features because I don't have time to fix them when they break and usually people who make them can't/won't support them afterwards. I can try to make an exception here because it seems like you've been pretty involved.
Combining bug fixes with reformatting and extra features is usually a good recipe for making it hard for me to easily review and merge.
The fastest way to get something merged:
- Make a low-impact bugfix
- Describe behaviour before and after the change
- If possible, have another user verify that the fix works on their machine.
I took some time to review this PR and found an issue in the arguments of sendMessage. If you clear that up I'll merge this. Thanks for your efforts.
|
ok, fixed that |
took 1 week to make this, but this feature is so easy to make
kill me plz
EDIT: also including #698, that pr is getting old