🔀 :: (#233) Fix can't collect LoginTokenResponse #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Entity변환 과정에서 emit하도록 변경
:: conflict fix
wjdcksdn
approved these changes
Jul 15, 2024
diejdkll
approved these changes
Jul 15, 2024
넵 그런 것 같습니다. transform이 새로운 Flow를 만들고 이를 emit해주는 방식으로 알고 있습니다. 추후 데이터의 복잡한 연산을 위해 transform형태는 유지하되 기존의 Response가 오는 형태의 API들에는 Repository단에서의 emit이 필요할 것 같아요. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 개요
로그인 시 AuthTokenResponse가 넘어오지만 UI Layer에서 ViewModel내의 Flow를 업데이트 하지 못해 Login이 성공했음에도 MainPage로 안넘어가짐
📃 작업내용
로그인 시 AuthTokenResponse가 넘어올때 Flow를 업데이트할 수 있도록 했습니다.
2024-05-28.2.35.23.mov
🔀 변경사항
로그인 시 AuthTokenResponse가 넘어올때 AuthRepository에서 emit하여 data를 발행해 업데이트를 감지할 수 있도록 변경하였습니다.
🙋♂️ 질문사항
Repository에서 emit하는 방식이 아닌 다른 좋은 방식이 있거나 컨벤션에 맞지 않는 부분 비효율적인 코드가 있다면 알려주세요.