Fixed: path-must-specify-tags #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lector to not fetch none "paths" paths
markbrockhoff
requested changes
Apr 30, 2024
| @@ -60,4 +65,115 @@ describe("path-must-specify-tags", () => { | |||
| }, | |||
| }, | |||
| }); | |||
|
|
|||
| const getComponentTestSpec = (tags?: string[], path = "/api/some/path") => | |||
| JSON.stringify({ | |||
There was a problem hiding this comment.
I don't think it's neccessary to have the full spec for this unit test. Only a path and a component should be neccessary to reproduce the issue.
.gitignore
Outdated
| @@ -1,6 +1,7 @@ | |||
| .vscode | |||
| demo* | |||
| node_modules | |||
| pnpm-lock.yaml | |||
There was a problem hiding this comment.
This repo is currenly using npm, please don't add pnpm related changes in this PR. However if you'd like to migrate this project to pnpm I'd be greatful for a seprate PR ;)
package.json
Outdated
| @@ -5,6 +5,7 @@ | |||
| "license": "Apache-2.0", | |||
| "devDependencies": { | |||
| "@stoplight/spectral-core": "^1.18.3", | |||
| "@stoplight/spectral-runtime": "^1.1.2", | |||
There was a problem hiding this comment.
Why was this dependency added? I guess this has something to do with the exclusion of the pnpm lockfile from git. Whenever a dependency is changed the lockfile should be updated as well which isn't the case here. Please use npm when working within this project to not corrupt the existing package-lock.json.
markbrockhoff
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I run into a bug in the path-must-specify-tags rule. If you define under schemas a model with a property that is named "get,post,put,delete,patch,options,head or trace" it will raise an error/warning.
I fixed it, by removing the 'dot' in the JSONPath under "given".
I wrote an additional test which will be raised when the dot is present in the given-selector.
Please check if the selector is correct - tested the selector with https://jsonpath.com/, but it gives me not the same result as the implementation of spectral.