Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appName that contains a - leads to an error in proto file #97

Closed
2 tasks done
brumhard opened this issue Mar 25, 2022 · 0 comments · Fixed by #138
Closed
2 tasks done

appName that contains a - leads to an error in proto file #97

brumhard opened this issue Mar 25, 2022 · 0 comments · Fixed by #138
Assignees
Labels
bug Something isn't working

Comments

@brumhard
Copy link
Contributor

What happened?

❯ make generate           
PATH=/private/tmp/awesome-project/bin:$PATH buf generate
api/proto/awesome-project/v1/awesome-project.proto:3:17:syntax error: unexpected '-', expecting ';'
make: *** [generate] Error 100

How can we reproduce this?

Create a new project using the following file (gt new -c values.yaml):

# values.yaml
base:
  projectName: Testing Project
  projectSlug: testing-project
  projectDescription: Some project used for testing
  appName: testing-project
  moduleName: github.com/fake/testing
  golangciVersion: 1.42.1
extensions:
  grpc:
    base: true

Then run make generate.

gt version

0.3.0

Search

  • I did search for other open and closed issues before opening this.

Code of Conduct

  • I agree to follow this project's Code of Conduct

Additional context

Probably the issue is the newly added support for dashes in appNames which are not allowed in protobuf.

@brumhard brumhard added the bug Something isn't working label Mar 25, 2022
@brumhard brumhard changed the title appName that contains a - lead to an error in proto file appName that contains a - leads to an error in proto file Mar 25, 2022
@brumhard brumhard mentioned this issue May 13, 2022
2 tasks
linuxluigi pushed a commit that referenced this issue Jun 28, 2022
* fix(template): replace hyphen with underscore in package name (#97)

* fix(template): remove hyphen in Service name (#97)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants