-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update YOLO
description to be more specific
#403
base: main
Are you sure you want to change the base?
Conversation
Thank you for the PR, but have you done any testing around this? |
Is it possible that this should be "merge without a review, but with a pending review request"? I have definitely merged a lot of PRs on my own repositories, but the one that made me get the badge was babel/minify#1034 |
OK, let me change the sentence a bit. In my experience the following did not work. FYI, I don't have YOLO badge so I can test which one does not work. |
Pls. make the YOLO Description more specific because I don't get this achievement |
good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the the condition to this:
Merged a pull request with reviewers requested but before any reviews
Quick update on the experiment YOLO PR #1. We confirmed that the guide how to earn YOLO badge is working. As described there all you need is
Let me know if you have any questions. |
@@ -22,7 +22,7 @@ Starstruck | ![Starstruck Badge](/images/starstruck-default.png) | ✔️ | Crea | |||
||| <!-- this empty row is intentional to separate --> | |||
Galaxy Brain | ![Galaxy Brain Badge](/images/galaxy-brain-default.png) | ✔️ | 2 accepted answers | |||
Pull Shark | ![Pull Shark Badge](/images/pull-shark-default.png) | ✔️ | 2 pull requests merged | |||
YOLO | ![YOLO Badge](/images/yolo-default.png) | ✔️ | Merged a pull request without code review | |||
YOLO | ![YOLO Badge](/images/yolo-default.png) | ✔️ | Merged a pull request on repository with multiple contributors without code review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as suggested by akira
YOLO | ![YOLO Badge](/images/yolo-default.png) | ✔️ | Merged a pull request on repository with multiple contributors without code review | |
YOLO | ![YOLO Badge](/images/yolo-default.png) | ✔️ | Merged a pull request with reviewers requested but before any reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest
Merged a pull request with at least one pending reviewer
resolve conflict ? |
@ParanoidUser It's good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it'll be more helpful.
No description provided.