Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update YOLO description to be more specific #403

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sgrokym
Copy link

@sgrokym sgrokym commented Sep 29, 2022

No description provided.

@Schweinepriester
Copy link
Owner

Thank you for the PR, but have you done any testing around this?
Because at least in the past this wasn't necessary, since for example my unlock doesn't fulfill said criteria: https://github.com/Schweinepriester?achievement=yolo&tab=achievements

@nicolo-ribaudo
Copy link

Is it possible that this should be "merge without a review, but with a pending review request"? I have definitely merged a lot of PRs on my own repositories, but the one that made me get the badge was babel/minify#1034

@Schweinepriester
Copy link
Owner

"merge without a review, but with a pending review request"

exactly this is my current status (proposed here and then verified with the PR which unlocked it for me).

but we know for sure they tinkered after the release, so…

@sgrokym
Copy link
Author

sgrokym commented Oct 1, 2022

OK, let me change the sentence a bit.
How about this one.
Merged a reviewable pull request without code review

In my experience the following did not work.
sgrokym/adr-jan#1
So, I think Merged a reviewable pull request without code review is more appropriate than Merged a pull request without code review

FYI, I don't have YOLO badge so I can test which one does not work.

@FleetAdmiralJakob
Copy link

Pls. make the YOLO Description more specific because I don't get this achievement

@Lymengchun
Copy link

good

Copy link

@akirataguchi115 akirataguchi115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the the condition to this:

Merged a pull request with reviewers requested but before any reviews

@ParanoidUser
Copy link

Quick update on the experiment YOLO PR #1. We confirmed that the guide how to earn YOLO badge is working.

As described there all you need is love follow the steps:

  1. Create any PR on any repository
  2. Assign another person as a reviewer. If you don't have any, invite somebody to collaborate.
  3. Accept the warning and merge the PR without review
  4. Celebrate your new profile badge.

Let me know if you have any questions.

@@ -22,7 +22,7 @@ Starstruck | ![Starstruck Badge](/images/starstruck-default.png) | ✔️ | Crea
||| <!-- this empty row is intentional to separate -->
Galaxy Brain | ![Galaxy Brain Badge](/images/galaxy-brain-default.png) | ✔️ | 2 accepted answers
Pull Shark | ![Pull Shark Badge](/images/pull-shark-default.png) | ✔️ | 2 pull requests merged
YOLO | ![YOLO Badge](/images/yolo-default.png) | ✔️ | Merged a pull request without code review
YOLO | ![YOLO Badge](/images/yolo-default.png) | ✔️ | Merged a pull request on repository with multiple contributors without code review
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as suggested by akira

Suggested change
YOLO | ![YOLO Badge](/images/yolo-default.png) | ✔️ | Merged a pull request on repository with multiple contributors without code review
YOLO | ![YOLO Badge](/images/yolo-default.png) | ✔️ | Merged a pull request with reviewers requested but before any reviews

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest
Merged a pull request with at least one pending reviewer

@marcos-jesus
Copy link

resolve conflict ?

@marcos-jesus
Copy link

@ParanoidUser It's good!

Copy link

@bitscoper bitscoper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it'll be more helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet