-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate webix datatable #1505
base: master
Are you sure you want to change the base?
Conversation
Quality Gate passedIssues Measures |
this.webixUi.refreshColumns(); | ||
} | ||
|
||
getWebixColumns(): any[] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method shows various possible (not all though) column configuration options. See Configuring Columns for more details
} | ||
|
||
initializeWebixTable(): void { | ||
this.webixUi = webix.ui({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
webix Datatable creation and configuration
Looks intriguing. Could the column filters replace the "Filter by..." sidebar? How is the performance? Do the sort and filter use the same indexes as in the previous implementation? |
Hi Spencer, thanks for the feedback.
Those are client side filtering and sorting handled by webix. From my other
projects I can say it can easily handle up 10K records.
Hence I do not think it should replace the search facets.
…On Mon, Jun 17, 2024, 15:20 Spencer Bliven ***@***.***> wrote:
Looks intriguing. Could the column filters replace the "Filter by..."
sidebar?
How is the performance? Do the sort and filter use the same indexes as in
the previous implementation?
—
Reply to this email directly, view it on GitHub
<#1505 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACZDFHG2N5E34CQ6A2DQUHTZH3PBRAVCNFSM6AAAAABJLFGYXOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZTGM4DCMBYGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Thanks for the proof-of-concept. |
Hi Max, thanks for the feedback!
Webix has many more widgets, not just tables. I would assume to replace all
visual components with it, hence provide consistent look and feel
experience.
However, I agree with you. This will introduce whole new abstraction layer
and may increase complexity and maintenance costs.
…On Mon, Jun 24, 2024, 17:26 Max Novelli ***@***.***> wrote:
Thanks for the proof-of-concept.
I'm hesitant to include another full fledged toolkit in the FE just to add
the table feature.
I worry that we are going to complicate more the code and make it even
more difficult to manage and maintain.
—
Reply to this email directly, view it on GitHub
<#1505 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACZDFHE6RHWU2IXNMCDIJNDZJA3CXAVCNFSM6AAAAABJLFGYXOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBWHA2DEOBZGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
We talked about this PR in the meeting today. A couple concerns came up.
|
Following the discussions at SciCatCon 2024 I will repurpose this PR to demonstrate how to plugins in SciCat FE |
Proof of the concept