-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create parcellation.ttl #49
Comments
@MFSY There are two ways we could do this
The only tradeoff I can see is that in order to get the metadata about a parcellation scheme you have to load the ontology file that defines that scheme. Thoughts? |
First pass can be seen here. |
Thank you Tom for this first version.
In the following, I’ll consider them equivalent. I’ll be happy to have more details about their respective differences though. Let see the three main questions I would like to see the ontology answer. That is to say the competency questions:
Answering the first question using the first version of the parcellation scheme ontology will require to only get direct subclasses of ilx:ilx_brain_parcellation_scheme_concept if we don’t want to maintain a list of brain parcellations files. The other subclasses correspond to brain regions. This sort of semantic should not be put in hierarchy depth I believe. I suggest then to separate the brain parcellation scheme and brain regions tanonomies as presented in the following picture: Also, developemental stage vocabulary exists from what I can see in bioportal with this query |
Thanks for the feedback. The short version is that I think the easiest way to meet all three competency questions is to create classes for information artefacts representing the atlases/parcellation schemes.
|
Further implementation reveals a need to distinguish between atlases, the parcellation schemes they use (not all parcellation schemes have extant and linkable/citeable atlases, eg HCP2016), and the parcellation scheme concepts contained/defined by the parcellation scheme. @MFSY's version has this correct. If we really need to model the atlses themselves we can either add them as links to scicrunch registry resources (if they exist) or to ilx terms that hold metadata on published texts (eg paxinos). |
I agree to distinguish between atlases, parcellation schemes and brain parcels (parcellation scheme concepts). In the version I proposed above, there is no concept of atlases as you pointed it out but only parcellation schemes and brain parcels. The only reason I see to have atlases as concepts (in the context of BBP) is to link specific metadata to it as you mentioned: version, release date, ... |
@MFSY I've pushed version 2. I also attached an updated diagram. Basically all I did was make it so that the parcellation concept had the relationship to the species and developmental stage instead of the artifact. I am currently using the developmental stage identifiers defined in NIFSTD since EFO xrefs them and it will be more expedient that trying to do a full integration of EFO. I can also change the annotation/object properties if needs be. For the competency questions, while we can't use a DL query to cross the isDefinedBy, scigraph has no problem traversing that edge with a neighbors query. We can get a complete listing of parcellation schemes from either the atlas root term or the parcellation concept root term. The following DL query returns all the parcellation concepts defined for mice |
Thank you. This new version can be used to answer the competency questions. I was wondering where the "P 56" in "adult P 56" developmental stage goes ? |
I suppose it could go in as a note or some other annotation property, maybe species specific developmental timepoint or something like that? P56 seems more like data than something we would want to make an explicit ontology class. Thoughts? |
It can goes in an annotation property, I think. |
I'm trying to check if the atlas we use in BBP-NIP are already available in the generated parcellations repository (here). I see that all brain parcel terms have two labels: ilx:parcellationLabel (original one) and rdfs:label (original label preceded by version information). I can see the usage of the version in parcel term's name (multiple atlas version can define the same brain parcel) but is it possible to use rdfs:label and some prefLabel from skos for that. The prefLabel being the label without version information. |
From what I recall from my conversation with Sean I still need to get Paxinos 2009 rat in. Yes, I will change to skos:prefLabel. |
Updated to |
This is in the master branch now. Just need to mint identifiers. As a note the |
ssSOs federated with uberon: http://obofoundry.org/ontology/mmusdv.html we have another 18 or so species |
These look like they can provide a good complement to the traditional E*/P* that shows up in many atlases. Will be interesting to compare with the terminology used by individual parcellation schemes. Thanks! |
Discussions from last week revealed that there is an additional level of abstraction here that we are not capturing explicitly, namely that the labels for a parcellation scheme, and the parcellation scheme are NOT the same thing. The parcellation scheme is the set of pairs of each label with the associated atlas artifact. Therefore we need to avoid prefixing the labels with the 'source' atlas artifact since there can be more than one atlas that uses the same labels. Some potential solutions to this issue.
|
Hi Tom - to handle that do you want to relate the parcellation label with a more global label as there maybe differing correspondences between parellation labels and the more global anatomical concepts? So you would end up with: So stick with something similar to (3)... |
Hi Tom, I would suggest the following solution:
The previous solution along with the elimination of brain atlas version mention in brain parcel labels will allows to get the brain parcels defined by a specific brain atlas by getting the subclasses of the "parcellation scheme concept" it defines. |
Just had a meeting with @jgrethe and @memartone and we encountered another use case which is to be able to add relationships between different versions of brain parcels that have the same labels but different atlas versions. For example if there is a change from one atlas version of MBA to the next we want to be able to flag that there was a change. Therefore it seems that we do indeed need to have explicit representation of the intersection between a parcellation label and an atlas. One way to do this is as follows.
This gives us a way to explicitly bind labels and atlases and make assertions about any changes that occur between those bindings for different versions of atlases. This will allow us to maintain partonomies on the labels (perhaps a bit confusing) that are asserted to hold across all atlases as well as atlas version specific hierarchies (e.g. the ones extract from vector representations of atlases). Thoughts? |
Here is an enumeration of the different ways that parcellation schemes can/could be ingested.
|
When writing up the docs for parcellation schemes also include #122. |
We may want a hierarchy for displaying regions on an interface (so that they are not just a flat list), which is not a 'proper' part-of relation. This might be true for partonomies defined only on labels (e.g. MBA) which are not borne out by the actual spatial structure of their corresponding atlas regions. BFO:0000050 could still be used for these, but it might be confusing since the atlas labels intentionally do not fit under the BFO schema. |
Additional competency questions to help guide the modelling of terms sourced from spatial anatomical sources as opposed to purely semantic sources.
|
Paxinos is nearly ready to go, I still need to sort out the issue with the layers and nuclei using the same numbers for abbreviations (sigh). |
Plate number and friends as a pseudospatial way to report with slightly more information. This falls somewhere between coordinate system and terminology. |
The text was updated successfully, but these errors were encountered: