-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove json file generating/posting in indexing (Ready for review) #33
Conversation
@kshefchek Would you know what version of Solr you're using in production? |
@kltm yes we are using 6.2.1 |
Okay, it's coming back to me now--wanting to make sure that no incompatibilities creep in, then remembering that we already tested for that. It all looks pretty sane to me, it seems more of a conversion than a complete rewrite (not to underplay all the work in there). |
No you are right - it is straight conversion and was not much work. I can make batch size a cmd line arg if that makes sense. |
Looks good |
great! I'll test this branch to index our three cores with our dev scigraph, fix tests, and update the docs. |
Batch size notes: For now going with 1k batches, it may be worth catching the socket exception and examining the documents to see if one contains an excessively large evidence graph. |
Conflicts: src/main/java/org/monarch/golr/GolrLoader.java
c3dd280
to
fae9ede
Compare
a25f938
to
a684f2c
Compare
See background ticket: #32
This PR replaces portions of code that convert Neo4J results to JSON, with code that converts Neo4J results to solr input doc objects and then adds them using SolrJ.
Note that the tests are now broken, I will fix or write new ones. To build:
mvn clean install -Dmaven.test.skip