Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failing for scikit-surgery #67

Closed
mianasbat opened this issue Sep 15, 2020 · 4 comments
Closed

Build failing for scikit-surgery #67

mianasbat opened this issue Sep 15, 2020 · 4 comments

Comments

@mianasbat
Copy link
Collaborator

mianasbat commented Sep 15, 2020

It seems that the build is failing for master branch of project scikit-surgery (https://github.com/UCL/scikit-surgery) . Is it because of the migration issues?

@tdowrick @thompson318 @MattClarkson

mianasbat added a commit that referenced this issue Sep 17, 2020
Added a workflow
@mianasbat
Copy link
Collaborator Author

The test log shows error No file or directory present on line 44 in test_docs_complete.py. I was exploring it and I found that os.listdir() is given relative path. I gave it absolute path i.e. /Users/mianasbatahmad/temp/scikit-surgery/modules and that specific error disappeared. I also found that os.listdir() is not very comfortable with relative path as discussed on https://bit.ly/2ZP838u
I am checking it more. Open for any hints, suggestions!

@mianasbat
Copy link
Collaborator Author

mianasbat commented Sep 18, 2020

Tom and I looked it this morning and that was very helpful. So one reason the tests were failing on my computer was that my modules directory contained .DS_Store directory and the code was looking for docs in all directories inside module directory. We added code to only consider directories starting with scikit- to fix it.

Secondly the submodules are empty directories (linked to respective repose) because I used git clone scikit-surgery when I should have used git clone --recursive scikit-surgery to download the submodules too as pointed by Tom. After this the file not found error should go away (ideally)

https://stackoverflow.com/questions/3796927/how-to-git-clone-including-submodules

We will need to figure out how to manage it in online testing.

@MattClarkson
Copy link
Contributor

Discussed 22/10/2020:

  • scikit-surgery is top-level management project, with docs. It doesn't itself contain code.
  • Remove badges, and CI, make it obvious that this project is just documentation

@tdowrick
Copy link
Collaborator

Closed by #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants