Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement U-Net #6

Open
bongjinkoo opened this issue Sep 28, 2020 · 1 comment
Open

Implement U-Net #6

bongjinkoo opened this issue Sep 28, 2020 · 1 comment
Assignees
@bongjinkoo

Comments

@bongjinkoo
Copy link
Collaborator

No description provided.

@bongjinkoo bongjinkoo changed the title implement-unet Implement U-Net Sep 28, 2020
bongjinkoo added a commit that referenced this issue Sep 29, 2020
@bongjinkoo
Issue #6: Implement U-Net and dataset class.
d4bc2bb
bongjinkoo added a commit that referenced this issue Sep 29, 2020
@bongjinkoo
Issue #6: Initial push.
0ecaa20
bongjinkoo added a commit that referenced this issue Sep 29, 2020
@bongjinkoo
Issue #6: Linting.
1097efe
@bongjinkoo bongjinkoo self-assigned this Sep 29, 2020
bongjinkoo added a commit that referenced this issue Sep 30, 2020
@bongjinkoo
Issue #6: Implement command line execution.
712fbba
bongjinkoo added a commit that referenced this issue Oct 1, 2020
@bongjinkoo
Issue #6: Fix training.
6f02627
bongjinkoo added a commit that referenced this issue Oct 6, 2020
@bongjinkoo
Issue #6: Add more loggings and validation.
b5b45e0
bongjinkoo added a commit that referenced this issue Jun 2, 2021
@bongjinkoo
Issue #6: Finish implementing U-Net.
c69cc2d
bongjinkoo added a commit that referenced this issue Jun 2, 2021
@bongjinkoo
Issue #6: Merge master.
b219956
bongjinkoo added a commit that referenced this issue Jun 2, 2021
@bongjinkoo
Issue #6: Change default epochs.
2283510
@mxochicale
Copy link
Collaborator

mxochicale commented Nov 3, 2022 •
edited

Reopening this one as few unit tests seems to be missing:

bongjinkoo, thanks for implementing this. In the absence of @MattClarkson and @tdowrick I took a look at it. How much work would be involved in implementing a unit test for the new code and in removing some of the pylint disable statements?:
#pylint:disable=invalid-name,too-many-locals,not-callable,too-many-branches,too-many-statements,abstract-method
thanks and regards, @thompson318

Will be addressed here #9

@mxochicale mxochicale reopened this Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bongjinkoo bongjinkoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MattClarkson @bongjinkoo @mxochicale