-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor VTKLUSSimulator to accept rot matrices for rendering #168
Comments
I can't find the setpose method. I found set_camera_pose inherherited from vtk_overlay_window but that seems to use matrices. Can you point to the setpose method please. |
It is because it is set_pose method I guess which is in |
Found it now, thanks. set_pose, not setpose |
Try and avoid having 2 methods with duplicate code. You could create set_pose_with_matrices, but then refactor the current set_pose method so all it does is convert the the pose parameters to matrices then calls set_pose_with_matrices |
…with_matrices method to allow for flexibility in parametrisation
@thompson318 see changes in #169 |
…y using matrices versus angle parametrisation
Issue #168: refactor set_pose method with new set_pose_with_matrices …
Issue Description
Currently, the set pose method for the VTKLUSSimulator accepts Euler angles, which are then converted into a rot matrix for rendering.
It would be useful to be able to directly pass rot matrices into the renderer, to avoid having to convert rot m -> euler angle -> back into rot m if the user is using rot ms.
The text was updated successfully, but these errors were encountered: