Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AD type for FiniteDifferences #11

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Conversation

devmotion
Copy link
Member

Maybe it would be reasonable to add a type for FiniteDifferences as well?

A bit inconsistent, in contrast to #10 in this PR I opted for a default value of nothing since I wanted to avoid pulling in FiniteDifferences which has much more dependencies than EnzymeCore. Alternatively, on Julia >= 1.9 one could add a weak dependency on FiniteDifferences and define a constructor with a more concrete default value such as FiniteDifferences.central_fdm(5, 1) (but this would lead to inconsistencies between Julia < 1.9 and >= 1.9...).

@Vaibhavdixit02
Copy link
Member

We should avoid that as you noted, for the extension we can do it separately but I think it might even be sufficient as it is now and the package using it can work around it

@Vaibhavdixit02 Vaibhavdixit02 merged commit 76daa27 into main Jul 19, 2023
3 checks passed
@Vaibhavdixit02 Vaibhavdixit02 deleted the dw/finitedifferences branch July 19, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants