Use more abstract types to create a hierarchy

[Vaibhavdixit02]

No description provided.

[ai-maintainer]

AI-Maintainer Review for PR - Use more abstract types to create a hierarchy

Title and Description ⚠️

The title is clear but the description is missing

The title of the pull request is clear and provides a concise summary of the changes. However, the description is missing. It would be beneficial to include a description that provides more context and explains the rationale for using more abstract types and creating a hierarchy.

Code Changes 👍

The changes are narrowly focused and relevant

The changes in the pull request are narrowly focused on introducing more abstract types to create a hierarchy. The diff primarily consists of the addition of new abstract types and their respective subtypes, along with a few modifications to existing types. There are no indications of the author attempting to resolve multiple issues simultaneously.

Testing ⚠️

Information about testing is missing

The description does not provide any information about how the changes were tested. It would be beneficial to include details about the testing approach taken to ensure the correctness and functionality of the introduced abstract types and their subtypes.

Documentation ⚠️

Docstrings for new types are missing

The newly added abstract types and their subtypes do not have docstrings. It would be beneficial to include docstrings that describe their behavior, arguments, and return values.

Suggested Changes

• Please add a description that provides more context and explains the rationale for the changes.
• Please provide information about how the changes were tested.
• Please add docstrings for the newly added abstract types and their subtypes.

Reviewed with AI Maintainer

[avik-pal]

Should we split Enzyme into forward and reverse modes to fit into this better?

[Vaibhavdixit02]

I was conflicted about this as well. The mode field should take the choice per the current definition. That can be the Enzyme Forward and Reverse objects directly, it's nothing because a default mode doesn't make sense to me it would be completely up the package if they want to put a default mode.

[Vaibhavdixit02]

Suggested change

	struct AutoEnzyme{M} <: AbstractADType
	struct AutoEnzyme{M} <: Union{AutoForwardMode, AutoReverseMode, AutoSparseForwardMode, AutoSparseReverseMode}

[Vaibhavdixit02]

This could be an option to keep dispatches happy 😅 but will put all the onus on the downstream package developer to make sure it's used with M being checked