Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upper bound diffeqbase and patch bandind error #152

Merged
merged 5 commits into from
Dec 21, 2023
Merged

Conversation

avik-pal
Copy link
Member

We were relying on the AbstractArray{<:AbstractArray} for specifying initial conditions. This is the last version to support that. We will transition to a VectorOfArray from v6

@avik-pal avik-pal marked this pull request as draft December 19, 2023 18:28
Copy link
Contributor

github-actions bot commented Dec 19, 2023

Benchmark Results

master 45374f4... t[master]/t[45374f4...]
Simple Pendulum/IIP/MultipleShooting(10, Tsit5; grid_coarsening = false) 1.8 ± 0.061 ms 1.83 ± 0.056 ms 0.98
Simple Pendulum/IIP/MultipleShooting(10, Tsit5; grid_coarsening = true) 3.31 ± 0.091 ms 3.36 ± 0.078 ms 0.986
Simple Pendulum/IIP/MultipleShooting(100, Tsit5; grid_coarsening = false) 0.052 ± 0.0033 s 0.0522 ± 0.0034 s 0.996
Simple Pendulum/IIP/MultipleShooting(100, Tsit5; grid_coarsening = true) 1.06 ± 0.0076 s 1.11 ± 0.0068 s 0.95
Simple Pendulum/IIP/Shooting(Tsit5()) 0.177 ± 0.0034 ms 0.232 ± 0.0064 ms 0.763
Simple Pendulum/OOP/MultipleShooting(10, Tsit5; grid_coarsening = false) 4.12 ± 0.19 ms 4.15 ± 0.16 ms 0.993
Simple Pendulum/OOP/MultipleShooting(10, Tsit5; grid_coarsening = true) 7.25 ± 3.9 ms 7.32 ± 4 ms 0.99
Simple Pendulum/OOP/MultipleShooting(100, Tsit5; grid_coarsening = false) 0.127 ± 0.0088 s 0.128 ± 0.0022 s 0.999
Simple Pendulum/OOP/MultipleShooting(100, Tsit5; grid_coarsening = true) 4.49 ± 0.00045 s 4.73 ± 0.001 s 0.951
Simple Pendulum/OOP/Shooting(Tsit5()) 0.697 ± 0.026 ms 0.792 ± 0.037 ms 0.88
time_to_load 8 ± 0.031 s 7.96 ± 0.032 s 1.01

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@avik-pal avik-pal marked this pull request as ready for review December 20, 2023 02:21
@avik-pal
Copy link
Member Author

Don't merge I will look into the NLLS, it is most likely LM that is causing all the trouble. LM seems to be robust but also works worse than TR in practice

@ChrisRackauckas ChrisRackauckas merged commit 23d29c9 into master Dec 21, 2023
11 checks passed
@ChrisRackauckas ChrisRackauckas deleted the ap/upperbound branch December 21, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants