Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Usage of ModelingToolkit Accessor Functions #242

Merged
merged 11 commits into from
Aug 5, 2020

Conversation

isaacsas
Copy link
Member

@isaacsas isaacsas commented Aug 4, 2020

Also fixed some test warnings on 1.5 due to scoping.

@isaacsas isaacsas mentioned this pull request Aug 4, 2020
@isaacsas isaacsas changed the title Graph tests Fix Usage of ModelingToolkit Accessor Functions and add Graph tests Aug 4, 2020
@isaacsas isaacsas mentioned this pull request Aug 4, 2020
@isaacsas isaacsas changed the title Fix Usage of ModelingToolkit Accessor Functions and add Graph tests Fix Usage of ModelingToolkit Accessor Functions Aug 5, 2020
@isaacsas
Copy link
Member Author

isaacsas commented Aug 5, 2020

Nope, they assume it has been installed by the user and is accessible through the commandline.

@isaacsas
Copy link
Member Author

isaacsas commented Aug 5, 2020

Not ideal, but the earlier Graphviz Julia library appears to be unmaintained, so it was this or something else. We could look into Graphplot -- that may still be being maintained to some degree. Overall it appeared the graph plotting tooling is not being maintained much at this point.

@ChrisRackauckas ChrisRackauckas merged commit 1dfe4aa into SciML:master Aug 5, 2020
@isaacsas isaacsas deleted the graph-tests branch August 5, 2020 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants