-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update API and docs for subsystems #407
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as/Catalyst.jl into update-api-for-subsystems
isaacsas
changed the title
[WIP] Update API and docs for subsystems
Update API and docs for subsystems
Sep 16, 2021
isaacsas
changed the title
Update API and docs for subsystems
[WIP] - Update API and docs for subsystems
Sep 16, 2021
isaacsas
changed the title
[WIP] - Update API and docs for subsystems
Update API and docs for subsystems
Sep 16, 2021
This should be good to go. Next would be adding |
ChrisRackauckas
approved these changes
Sep 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. isequal_without_names
is an odd name but it makes sense.
I’ll merge but change it if I come up with something better… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #404 to make as many API functions work with subsystems, and give an error message for those that don't support a
ReactionSystem
with subsystems.Main changes:
species
,reactionparams
, andreactions
now collect the states, parameters, andReaction
s from only those subsystems that areReactionSystem
s. This leaves the normal MT API (states
,parameters
,equations
) to return larger sets that may include components from non-ReactionSystem
subsystems. This seemed like a reasonable division to me,but we'll need further doc updates to make the distinction clear.params
andnumparm
s since we now have eitherparameters
orreactionparams
depending on what a user wants.merge
since we now haveMT.extend
.