Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API and docs for subsystems #407

Merged
merged 14 commits into from
Sep 16, 2021

Conversation

isaacsas
Copy link
Member

@isaacsas isaacsas commented Sep 16, 2021

Follow up to #404 to make as many API functions work with subsystems, and give an error message for those that don't support a ReactionSystem with subsystems.

Main changes:

  1. species, reactionparams, and reactions now collect the states, parameters, and Reactions from only those subsystems that are ReactionSystems. This leaves the normal MT API (states, parameters, equations) to return larger sets that may include components from non-ReactionSystem subsystems. This seemed like a reasonable division to me, but we'll need further doc updates to make the distinction clear .
  2. Depreciated with a warning params and numparms since we now have either parameters or reactionparams depending on what a user wants.
  3. Depreciated merge since we now have MT.extend.

@isaacsas isaacsas changed the title [WIP] Update API and docs for subsystems Update API and docs for subsystems Sep 16, 2021
@isaacsas isaacsas changed the title Update API and docs for subsystems [WIP] - Update API and docs for subsystems Sep 16, 2021
@isaacsas isaacsas changed the title [WIP] - Update API and docs for subsystems Update API and docs for subsystems Sep 16, 2021
@isaacsas
Copy link
Member Author

This should be good to go. Next would be adding @add_constraints.

Copy link
Member

@ChrisRackauckas ChrisRackauckas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. isequal_without_names is an odd name but it makes sense.

@isaacsas
Copy link
Member Author

I’ll merge but change it if I come up with something better…

@isaacsas isaacsas merged commit f103db4 into SciML:master Sep 16, 2021
@isaacsas isaacsas deleted the update-api-for-subsystems branch September 16, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants