Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix Symbolics related stuff #887

Merged
merged 17 commits into from
Jun 8, 2024
Merged

[WIP] Fix Symbolics related stuff #887

merged 17 commits into from
Jun 8, 2024

Conversation

TorkelE
Copy link
Member

@TorkelE TorkelE commented May 29, 2024

Update, right now this one covers most stuff symbolics/equation related.

  • Replaced Symbolics.istree with TermInterface.iscall.
  • Reactivated tests that should no longer be broken due to a recent Symbolcis update.
  • Updates compats for new Symbolics.
  • Remove SymboliUtils dependency, and all function calls of it (where possible).
  • Introduces the new hasnode and replacenode symbolic functions (instead of _occursin and replace).

@TorkelE
Copy link
Member Author

TorkelE commented May 29, 2024

Issue for the SDE thing: SciML/ModelingToolkit.jl#2754

@TorkelE TorkelE closed this May 31, 2024
@TorkelE TorkelE reopened this May 31, 2024
Copy link
Member

@isaacsas isaacsas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to merge once runtests.jl is updated.

@TorkelE TorkelE changed the title Fix tests [WIP] Fix tests Jun 5, 2024
@isaacsas
Copy link
Member

isaacsas commented Jun 7, 2024

Should this be good now that MTK has been updated (modulo updating runtests here)?

@TorkelE
Copy link
Member Author

TorkelE commented Jun 7, 2024

Turns out that StructuralIdentifiability is not compatible with the latest versions (although just checking the project.toml file it should be, so might be some of its dependencies which is causing it): SciML/StructuralIdentifiability.jl#326

Later today I plan to temporarily disable the SI extension and stuff so that it all passes. Then when SI is updated (which I imagine and hope will be soon), it should be a very quick thing to add it back in.

@TorkelE TorkelE changed the title [WIP] Fix tests [WIP] Fix Symbolics related stuff Jun 8, 2024
Project.toml Outdated Show resolved Hide resolved
Copy link
Member

@isaacsas isaacsas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn’t this also bump MTK and Symbolics to the latest versions that have SymbolicUtils V2 support?

@TorkelE
Copy link
Member Author

TorkelE commented Jun 8, 2024

yes it should

docs/Project.toml Outdated Show resolved Hide resolved
@isaacsas
Copy link
Member

isaacsas commented Jun 8, 2024

Cool, feel free to merge when you are done then. Once this is merged I will continue with some doc updates, but I want to wait until I can build with SymbolicUtils V2.

@TorkelE
Copy link
Member Author

TorkelE commented Jun 8, 2024

Will merge as soon as everything has passed.

@TorkelE TorkelE merged commit 4fcedea into master Jun 8, 2024
6 of 7 checks passed
@TorkelE TorkelE deleted the symbolics_fixes branch June 8, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants