Adding cycles/flux mode calculation #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacsas
requested changes
Jun 28, 2024
isaacsas
requested changes
Jul 12, 2024
There was a problem hiding this comment.
It would probably be good to get a few more tests for systems with/without cycles if possible (even simple cases).
isaacsas
reviewed
Jul 12, 2024
|
If you can update to master I'll merge this then. |
isaacsas
approved these changes
Jul 16, 2024
|
CI is failing? |
Hmm yeah something weird seems to have happened to the test file when I merged master, looking into it |
|
Still seems there are conflicts with master? |
|
OK, LGTM. Feel free to merge at your leisure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Computing cycles/flux modes of reaction networks, working on caching equations with a similar format to the functionality for conservation laws.