Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runtest file #923

Merged
merged 0 commits into from
Jun 8, 2024
Merged

Fix runtest file #923

merged 0 commits into from
Jun 8, 2024

Conversation

TorkelE
Copy link
Member

@TorkelE TorkelE commented Jun 7, 2024

When I tried to parallelise the tests I introduced some groupings, which were then commented out when it turned out more complicated than expected. Since we do not expect these to be used anytime soon, they probably should be dropped.

I know David Anthoff is working on an updated version of https://github.com/julia-vscode/TestItemRunner.jl (which currently exists, but is experimental) which will include good parallelisation support. Once that happens, we should probably take a look at this again.

Copy link
Member

@isaacsas isaacsas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity what was the issue with grouping (i.e. why couldn’t we mimic OrdinaryDiffEq)?

@TorkelE
Copy link
Member Author

TorkelE commented Jun 7, 2024

To be honest, I have forgotten exactly. I tried just copying stuff, and I did manage so that there were separate test runs for each, however, they would all fail. I asked around in the JuliaLab for help, but the only one who had any input was Avik, who told me to just switch to ReTestItems (I think he is also lobbying to make that a general SciML thing).

@TorkelE TorkelE merged commit 1a4a816 into master Jun 8, 2024
2 of 4 checks passed
@TorkelE TorkelE deleted the revert_testfile branch June 8, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants