Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry @isaacsas I messed up when we updated this one. I think the
warnonly
lists the warning types that does not generate errors and instead only warnings (withwarnonly = true
being equivalent to listing all).This update should prevent doc build errors from missing cross_references and footnotes that occur as an entry only.
For the missing cross_references I plan to make an update today/tomorrow which removes all
[text](@ref ref)
entries. They are meant to mark places where we should put an entry when the doc they reference is added (e.g. Jump performance). However, having a PR which just removes them from the text should be enough, later on, I can just check that one where there were changes and add them back in.The footnote thing we use in a few places where there are general references that does not directly fit in, e.g.
![image](https://private-user-images.githubusercontent.com/18099310/337916366-c19e12ef-762b-4512-a436-3ec44f3b1653.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk3OTgwOTQsIm5iZiI6MTcxOTc5Nzc5NCwicGF0aCI6Ii8xODA5OTMxMC8zMzc5MTYzNjYtYzE5ZTEyZWYtNzYyYi00NTEyLWE0MzYtM2VjNDRmM2IxNjUzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzAxVDAxMzYzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE2YWJlOWFmOGJhZjc3YmE3ZDI2NDM0MjFmYWI4ZmRjNmM5N2VlOTZjMDA4ZGM0ZWVjZmEwNGQ5ZmU0NWExMzYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.SF8yP-KxYehJFEYMvLA5B3-OWmB5Q_O2CIWQw-x3Efk)
In the intro to Catalyst for new Julia users doc, so I think that one should probably stay.