DEStats additon from SciMLBase #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use the Destats from SciMLBase
This has no been tested locally and should allow for parallel execution of DDE
devmotion
reviewed
Feb 22, 2024
There was a problem hiding this comment.
I haven't follow the stats updates in SciMLBase closely, but if we should/have to switch to DEStats then I assume we can remove the DDEStats definitions completely. We should also make sure that the compat entries for SciMLBase are correct (such that DEStats is actually available).
devmotion
reviewed
Feb 22, 2024
src/solve.jl
Outdated
| @@ -166,7 +166,8 @@ function DiffEqBase.__init(prob::DiffEqBase.AbstractDDEProblem, | |||
| Val(isinplace(prob))) | |||
|
|
|||
| # separate statistics of the integrator and the history | |||
| stats = DDEStats(0) | |||
| #stats = DDEStats(0) | |||
There was a problem hiding this comment.
Suggested change
| #stats = DDEStats(0) |
There was a problem hiding this comment.
You are correct I should have provided more context, this change steps out of a conversation on slack
https://julialang.slack.com/archives/CN04R7WKE/p1708095479463839
|
When JuliaRegistries/General#101462 is merged, bump the lower bound here and I'll merge when tests pass. |
|
Should still remove the DDEStats implementation completely, I guess? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add any other context about the problem here.
This utilise DEStats from SciML base to allow for parallel executions of DDE