-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEStats additon from SciMLBase #283
Conversation
use the Destats from SciMLBase
This has no been tested locally and should allow for parallel execution of DDE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't follow the stats updates in SciMLBase closely, but if we should/have to switch to DEStats
then I assume we can remove the DDEStats
definitions completely. We should also make sure that the compat entries for SciMLBase are correct (such that DEStats
is actually available).
src/solve.jl
Outdated
@@ -166,7 +166,8 @@ function DiffEqBase.__init(prob::DiffEqBase.AbstractDDEProblem, | |||
Val(isinplace(prob))) | |||
|
|||
# separate statistics of the integrator and the history | |||
stats = DDEStats(0) | |||
#stats = DDEStats(0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#stats = DDEStats(0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are correct I should have provided more context, this change steps out of a conversation on slack
https://julialang.slack.com/archives/CN04R7WKE/p1708095479463839
When JuliaRegistries/General#101462 is merged, bump the lower bound here and I'll merge when tests pass. |
Should still remove the DDEStats implementation completely, I guess? |
Add any other context about the problem here.
This utilise DEStats from SciML base to allow for parallel executions of DDE