Adds CallbackCache #229
Merged
Adds CallbackCache #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| prev_sign::signType | ||
| end | ||
|
|
||
| function CallbackCache(max_len,conditionType::Type,signType::Type) |
There was a problem hiding this comment.
It may need to be Type{conditionType}, Type{signType) where {conditionType,signType} to specialize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make all the callback's temporary registers come in one place, this PR introduces a new structure
CallbackCache. Changes required in OrdinaryDiffEq are also made in the PR SciML/OrdinaryDiffEq.jl#754. I am also trying to convertnext_signandprev_signtoBitArraybut it seems that handling Floating Point error is tricky with this. Also we need to handle the case when condition at time steps is zero differently.