add step!(integ, Δt)

[Datseris]

No description provided.

[ChrisRackauckas]

@tkf I like this extension better than a separate name, thoughts?

[ChrisRackauckas]

Just make that dt instead of Δt to match the naming convention. It doesn't actually effect usage though.

[Datseris]

Are the individual step! for each package defined within the package? Like e.g. OrdinaryDiffEq? I was expecting to see a simple function step! end in DiffEqBase.

We have to be careful whether we need to add import DiffEqBase: step!

[codecov]

Codecov Report

Merging #85 into master will decrease coverage by 0.05%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
- Coverage   19.48%   19.43%   -0.06%     
==========================================
  Files          34       34              
  Lines        1129     1132       +3     
==========================================
  Hits          220      220              
- Misses        909      912       +3

Impacted Files	Coverage Δ
src/integrator_interface.jl	0% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87d5794...048f080. Read the comment docs.

[ChrisRackauckas]

Yes, the step! implementations are in the packages, but this doesn't need to know about them since it will just be calling the overloads internally. So this will generically work even though it's defined before the actual implementations.

[Datseris]

I like docstrings. I added one! Is it correct?

[coveralls]

Coverage decreased (-0.05%) to 19.435% when pulling 7092d2c on Datseris:patch-1 into 87d5794 on JuliaDiffEq:master.

[ChrisRackauckas]

Put it on the generic definition at the top.

[ChrisRackauckas]

Seems great to me.

Though right after merging it, maybe there should be an arg stop_at_t = false to add a tstop at t+dt (add_tstop!(integ,t+dt)), and it should check >= instead of > to be more robust. @Datseris would you like to PR that to finish it up?

[Datseris]

Hi, thanks for merging it.

I won't have time to do the change you suggested today, but if it is a small 4 liner, maybe you can just go ahead and do it?