Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Extend collocation methods to use DataInterpolations.jl #380

Merged
merged 5 commits into from
Jan 12, 2021

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Aug 2, 2020

Follows from discussion on Non-Smooth Collocation Methods in #370

src/collocation.jl Outdated Show resolved Hide resolved
@ChrisRackauckas
Copy link
Member

Okay, this is interesting. It seems that the DataInterpolations PR broke master and it's the same error error. The test in question wants to use the derivative w.r.t. the data of the interpolation.

https://github.com/PumasAI/DataInterpolations.jl/blob/master/src/DataInterpolations.jl#L24-L27

That DoesNotExist() I think should be interpreted as the derivative of the output w.r.t. the parameters. The thing acts as an array, https://github.com/PumasAI/DataInterpolations.jl/blob/master/src/DataInterpolations.jl#L9-L10 so I think it just needs to send back an array of mostly zeros and the local stencil coefficients in the right place.

@ChrisRackauckas ChrisRackauckas merged commit 2eb0b7e into SciML:master Jan 12, 2021
@ChrisRackauckas ChrisRackauckas deleted the ap/collocation branch January 12, 2021 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants