Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix continuous callbacks #70

Merged
merged 2 commits into from
Aug 22, 2020
Merged

fix continuous callbacks #70

merged 2 commits into from
Aug 22, 2020

Conversation

ChrisRackauckas
Copy link
Member

Before, this was:

function continuous_affect!_kernel(affect!,event_idx,u,t,p)
    @loop for i in ((event_idx,); (blockIdx().x-1) * blockDim().x + threadIdx().x)
        @views @inbounds affect!(FakeIntegrator(u[:,i],t,p[:,i]))
        nothing
    end
    nothing
end

@vchuravy could I get a quick check to see if this makes sense? This a kind of weird case where we really just want to launch a kernel mostly to hit the same abstraction: event_idx is even an integer most of the time, but we want to run this function on the GPU just because the values are already on the GPU.

@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #70 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #70   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           1       1           
  Lines         264     264           
======================================
  Misses        264     264           
Impacted Files Coverage Δ
src/DiffEqGPU.jl 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd60da8...10de5ca. Read the comment docs.

@ChrisRackauckas ChrisRackauckas merged commit 13886fc into master Aug 22, 2020
@ChrisRackauckas ChrisRackauckas deleted the continuous branch August 22, 2020 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant