CompatHelper: bump compat for Copulas to 0.1, (keep existing compat) #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #134 +/- ##
==========================================
- Coverage 93.11% 92.28% -0.83%
==========================================
Files 11 11
Lines 842 830 -12
==========================================
- Hits 784 766 -18
- Misses 58 64 +6 ☔ View full report in Codecov by Sentry. |
Specialize on Gaussian and Independent copulas only.
Merged
Fix Shapley method
devmotion
reviewed
Apr 4, 2024
| if n_dep == 1 | ||
| dist_cond = Normal(cond_mean[1, 1], cond_var[1, 1]) | ||
| sample_norm = rand(dist_cond, n_sample) | ||
| dist_cond = Normal(cond_mean[1, 1], sqrt(cond_var[1, 1])) |
There was a problem hiding this comment.
I didn't rerun the tests locally... I wonder if the test errors are caused by this fix (stddev instead of variance).
There was a problem hiding this comment.
yes that should be it. Fwiw the values for ishigami function are closer to the sobol indices now so it's not suspicious
There was a problem hiding this comment.
closer in a handwavy way lol
Vaibhavdixit02
deleted the
compathelper/new_version/2023-11-14-23-08-53-265-03909794485
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
Copulaspackage from=0.1.13to=0.1.13, 0.1.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.