factorization

SciML · Apr 19, 2022 · f43c264 · f43c264
1 parent be73e8f
commit f43c264
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/common.jl b/src/common.jl
@@ -96,9 +96,9 @@ function SciMLBase.init(prob::LinearProblem, alg::Union{SciMLLinearSolveAlgorith
         fill!(u0,false)
     end
 
-    # TODO
-    if solve_adjoint === true
-        A = A'
+    if solve_adjoint & !(alg isa Union{AbstractFactorization,
+                                       AbstractSolveFunction})
+       A = A'
     end
 
     cacheval = init_cacheval(alg, A, b, u0, Pl, Pr, maxiters, abstol, reltol, verbose)

diff --git a/src/factorization.jl b/src/factorization.jl
@@ -11,7 +11,9 @@ function SciMLBase.solve(cache::LinearCache, alg::AbstractFactorization; kwargs.
         fact = do_factorization(alg, cache.A, cache.b, cache.u)
         cache = set_cacheval(cache, fact)
     end
-    y = _ldiv!(cache.u, cache.cacheval, cache.b)
+    fact = cache.solve_adjoint ? cache.cacheval' : cache.cacheval
+
+    y = _ldiv!(cache.u, fact, cache.b)
     SciMLBase.build_linear_solution(alg,y,nothing,cache)
 end