custom linear solve function #112

vpuri3 · 2022-04-01T15:36:38Z

~~fixes #110~~

would be good to have

vpuri3 · 2022-04-01T15:44:10Z

suggestion from Daniel Wennberg on DiffEq-bridged from Julia Slack

if applicable(ldiv!, A, b)
    [ldiv! code]
else
    [no-ldiv! code]
end

vpuri3 · 2022-04-01T21:21:19Z

julia> using LinearSolve, LinearAlgebra;prob=LinearProblem(Diagonal(rand(4)),rand(4);u0=rand(4)); alg=FunctionCall(ldiv!, (:u, :A, :b)); cache=SciMLBase.init(prob, alg); solve(cache)
u: 4-element Vector{Float64}:
 0.07077439381665458
 1.22568741027046
 1.2092496048689403
 1.3612307917964956

alg works. now need to figure out default triage

ChrisRackauckas · 2022-04-01T21:59:42Z

For the diagonal case, it would probably be best just keep the standard format via using factorize

julia> A = Diagonal(rand(2))
2×2 Diagonal{Float64, Vector{Float64}}:
 0.241201   ⋅
  ⋅        0.0374477

julia> factorize(A)
2×2 Diagonal{Float64, Vector{Float64}}:
 0.241201   ⋅
  ⋅        0.0374477

which should be the current default?

ChrisRackauckas · 2022-04-01T22:01:23Z

src/default.jl

    if A isa DiffEqArrayOperator
        A = A.A
    end

+    if applicable(ldiv!, A, u)


is this check static?

vpuri3 · 2022-04-03T18:27:26Z

i don't understand what's causing type instability so ive pushed a few options to src/function_call.jl. LMK what their comparative performance advantages are. Ive added the use cases in test/basictests.jl. the ability to define custom inverse functions for custom types or standard types would be cool to have.

ive also reverted all changes to default.jl so we can figure ^ out first

vpuri3 · 2022-04-05T12:31:39Z

src/function_call.jl

+
+##
+
+""" apply ldiv!(A, u) """


this will be type stable, correct @ChrisRackauckas ?

ChrisRackauckas · 2022-04-06T01:33:03Z

The more sane way of doing this is to just impose a function syntax. For example, impose that it's always (u,A,b), but don't force that a function uses all of them. You probably want to take a conservatively large set of possible arguments for that.

vpuri3 · 2022-04-06T18:07:50Z

CI

vpuri3 · 2022-04-06T18:19:25Z

weird tests didn't run. closing/opening again

vpuri3 · 2022-04-06T18:20:59Z

@ChrisRackauckas can you take a look, and run CI? tests aren't running for me

ChrisRackauckas · 2022-04-06T20:10:18Z

Needs documentation.

ChrisRackauckas · 2022-04-06T20:10:47Z

Otherwise I think this looks good to go.

ChrisRackauckas · 2022-04-06T20:12:31Z

Rebase this onto master.

codecov · 2022-04-06T21:38:44Z

Codecov Report

Merging #112 (b692761) into main (1186046) will increase coverage by 1.05%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
+ Coverage   58.15%   59.20%   +1.05%     
==========================================
  Files          10       11       +1     
  Lines         595      603       +8     
==========================================
+ Hits          346      357      +11     
+ Misses        249      246       -3

Impacted Files	Coverage Δ
src/LinearSolve.jl	`20.00% <0.00%> (-5.00%)`	⬇️
src/common.jl	`73.91% <100.00%> (+8.69%)`	⬆️
src/solve_function.jl	`100.00% <100.00%> (ø)`

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

…to vp-ldiv

vpuri3 · 2022-04-06T21:52:40Z

rebased, tests passing

vpuri3 · 2022-04-06T22:16:53Z

merge, @ChrisRackauckas ?

ChrisRackauckas · 2022-04-06T22:22:25Z

Needs docs.

coveralls · 2022-04-06T23:54:26Z

Pull Request Test Coverage Report for Build 2105740759

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

8 of 9 (88.89%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+59.6%) to 59.635%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/LinearSolve.jl	0	1	0.0%

Totals
Change from base Build 2104845930:	59.6%
Covered Lines:	359
Relevant Lines:	602

💛 - Coveralls

vpuri3 · 2022-04-07T00:02:20Z

docs added

ChrisRackauckas · 2022-04-07T02:48:05Z

src/solve_function.jl

+end
+
+Base.@kwdef struct LinearSolveFunction{F} <: AbstractSolveFunction
+    solve_func::F = DEFAULT_LINEAR_SOLVE


I don't think there should be a default here. If they use LinearSolveFunction, they are explicitly opting out of using the default, so it would be unsafe to just make it fallback. Instead, it should error and say hey, didn't you wish to provide a function here?

src/solve_function.jl

test/basictests.jl

initial commit

3fad3c9

vpuri3 mentioned this pull request Apr 1, 2022

default branching to factorization on Diagonal type #110

Closed

vpuri3 added 3 commits April 1, 2022 12:29

use builtin function applicable instead

1a8261b

functioncall struct

caa1bee

works. now need figure out default triage

5aefad0

ChrisRackauckas reviewed Apr 1, 2022

View reviewed changes

src/default.jl Outdated

if A isa DiffEqArrayOperator

A = A.A

end

if applicable(ldiv!, A, u)

Copy link

Member

ChrisRackauckas Apr 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this check static?

vpuri3 added 3 commits April 1, 2022 21:57

ldiv

5b6dff3

reverting

bf5ea7f

test cases

0f7bf2b

vpuri3 added 2 commits April 4, 2022 13:40

need_concrete_A

f46565a

defaults

b7e8667

vpuri3 commented Apr 5, 2022

View reviewed changes

src/function_call.jl Outdated

##

""" apply ldiv!(A, u) """

Copy link

Member Author

vpuri3 Apr 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will be type stable, correct @ChrisRackauckas ?

impose function syntax

628ff57

vpuri3 closed this Apr 6, 2022

vpuri3 reopened this Apr 6, 2022

vpuri3 changed the title ~~[WIP] use ldiv! if available~~ use ldiv! if available Apr 6, 2022

vpuri3 changed the title ~~use ldiv! if available~~ custom linear solve function Apr 6, 2022

vpuri3 closed this Apr 6, 2022

vpuri3 reopened this Apr 6, 2022

ChrisRackauckas closed this Apr 6, 2022

ChrisRackauckas reopened this Apr 6, 2022

bump ci?

2671a71

Update README.md

8ba630a

vpuri3 added 5 commits April 6, 2022 17:30

ldiv

340e67d

test cases

1f7a20b

defaults

c4ca9ff

impose function syntax

8ddd436

impose function syntax

e3e8a9f

vpuri3 added 4 commits April 6, 2022 17:39

Merge branch 'vp-ldiv' of https://github.com/vpuri3/LinearSolve.jl in…

a232e44

…to vp-ldiv

rm'd copy of solve-function testset

85f8fd6

rmd copy of solve-function testset

6dd5925

Merge branch 'vp-ldiv' of https://github.com/vpuri3/LinearSolve.jl in…

2461a44

…to vp-ldiv

vpuri3 added 2 commits April 6, 2022 19:48

docs

fe964ef

Merge branch 'main' into vp-ldiv

ddbefe1

typo

c7d8f03

ChrisRackauckas reviewed Apr 7, 2022

View reviewed changes

src/solve_function.jl Outdated Show resolved Hide resolved

Update src/solve_function.jl

444d69f

ChrisRackauckas reviewed Apr 7, 2022

View reviewed changes

test/basictests.jl Outdated Show resolved Hide resolved

Update test/basictests.jl

b692761

ChrisRackauckas approved these changes Apr 7, 2022

View reviewed changes

ChrisRackauckas merged commit c960f8f into SciML:main Apr 7, 2022

vpuri3 deleted the vp-ldiv branch April 7, 2022 12:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

custom linear solve function #112

custom linear solve function #112

vpuri3 commented Apr 1, 2022 •

edited

Loading

vpuri3 commented Apr 1, 2022

vpuri3 commented Apr 1, 2022

ChrisRackauckas commented Apr 1, 2022

ChrisRackauckas Apr 1, 2022

vpuri3 commented Apr 3, 2022 •

edited

Loading

vpuri3 Apr 5, 2022

ChrisRackauckas commented Apr 6, 2022

vpuri3 commented Apr 6, 2022

vpuri3 commented Apr 6, 2022

vpuri3 commented Apr 6, 2022

ChrisRackauckas commented Apr 6, 2022

ChrisRackauckas commented Apr 6, 2022

ChrisRackauckas commented Apr 6, 2022

codecov bot commented Apr 6, 2022 •

edited

Loading

vpuri3 commented Apr 6, 2022 •

edited

Loading

vpuri3 commented Apr 6, 2022

ChrisRackauckas commented Apr 6, 2022

coveralls commented Apr 6, 2022 •

edited

Loading

vpuri3 commented Apr 7, 2022

ChrisRackauckas Apr 7, 2022

custom linear solve function #112

custom linear solve function #112

Conversation

vpuri3 commented Apr 1, 2022 • edited Loading

vpuri3 commented Apr 1, 2022

vpuri3 commented Apr 1, 2022

ChrisRackauckas commented Apr 1, 2022

ChrisRackauckas Apr 1, 2022

Choose a reason for hiding this comment

vpuri3 commented Apr 3, 2022 • edited Loading

vpuri3 Apr 5, 2022

Choose a reason for hiding this comment

ChrisRackauckas commented Apr 6, 2022

vpuri3 commented Apr 6, 2022

vpuri3 commented Apr 6, 2022

vpuri3 commented Apr 6, 2022

ChrisRackauckas commented Apr 6, 2022

ChrisRackauckas commented Apr 6, 2022

ChrisRackauckas commented Apr 6, 2022

codecov bot commented Apr 6, 2022 • edited Loading

Codecov Report

vpuri3 commented Apr 6, 2022 • edited Loading

vpuri3 commented Apr 6, 2022

ChrisRackauckas commented Apr 6, 2022

coveralls commented Apr 6, 2022 • edited Loading

Pull Request Test Coverage Report for Build 2105740759

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

vpuri3 commented Apr 7, 2022

ChrisRackauckas Apr 7, 2022

Choose a reason for hiding this comment

vpuri3 commented Apr 1, 2022 •

edited

Loading

vpuri3 commented Apr 3, 2022 •

edited

Loading

codecov bot commented Apr 6, 2022 •

edited

Loading

vpuri3 commented Apr 6, 2022 •

edited

Loading

coveralls commented Apr 6, 2022 •

edited

Loading